Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't take ownership for messages where not necessary #84

Merged
merged 7 commits into from
Feb 26, 2024
Merged

Conversation

mulmarta
Copy link
Contributor

Removes a bunch of clone's. Receiving message still takes ownership due to wide-spread usage of AuthenticatedContent which takes ownership even though it wouldn't need to.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mulmarta mulmarta requested a review from a team as a code owner February 22, 2024 11:57
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.74534% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 88.87%. Comparing base (13eba2c) to head (ac27866).

Files Patch % Lines
mls-rs/src/group/util.rs 63.46% 19 Missing ⚠️
mls-rs/src/group/message_processor.rs 12.50% 7 Missing ⚠️
mls-rs-uniffi/src/lib.rs 0.00% 2 Missing ⚠️
mls-rs/src/client.rs 90.00% 1 Missing ⚠️
mls-rs/src/group/framing.rs 80.00% 1 Missing ⚠️
mls-rs/src/group/mod.rs 97.72% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   88.88%   88.87%   -0.02%     
==========================================
  Files         171      171              
  Lines       31194    31109      -85     
==========================================
- Hits        27727    27648      -79     
+ Misses       3467     3461       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomleavy tomleavy merged commit fd94672 into main Feb 26, 2024
20 checks passed
@tomleavy tomleavy deleted the ref2 branch February 26, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants