Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a serde feature and derive serde for most structs used by providers #76

Merged
merged 11 commits into from
Feb 13, 2024

Conversation

mulmarta
Copy link
Contributor

@mulmarta mulmarta commented Feb 5, 2024

Allows more convenient providers implementations, e.g. with JSONs for debug. Changes mechanical.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mulmarta mulmarta requested a review from a team as a code owner February 5, 2024 19:12
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (105faf3) 91.47% compared to head (393006d) 91.46%.
Report is 2 commits behind head on main.

Files Patch % Lines
mls-rs/src/tree_kem/math.rs 90.24% 8 Missing ⚠️
mls-rs/src/group/commit.rs 81.81% 2 Missing ⚠️
mls-rs/src/group/mod.rs 91.66% 2 Missing ⚠️
mls-rs/src/group/secret_tree.rs 97.01% 2 Missing ⚠️
mls-rs/src/tree_kem/parent_hash.rs 93.75% 1 Missing ⚠️
mls-rs/src/tree_kem/tree_hash.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   91.47%   91.46%   -0.01%     
==========================================
  Files         169      168       -1     
  Lines       30319    30307      -12     
==========================================
- Hits        27733    27720      -13     
- Misses       2586     2587       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mls-rs-core/Cargo.toml Outdated Show resolved Hide resolved
mls-rs-core/Cargo.toml Outdated Show resolved Hide resolved
stefunctional
stefunctional previously approved these changes Feb 9, 2024
Copy link
Contributor

@tomleavy tomleavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just need to put a base64 transform anywhere that we have serde where we use bytevec for the mls side

mls-rs-core/src/crypto.rs Outdated Show resolved Hide resolved
mls-rs-core/src/lib.rs Outdated Show resolved Hide resolved
mls-rs-core/src/lib.rs Outdated Show resolved Hide resolved
mls-rs-core/src/lib.rs Outdated Show resolved Hide resolved
mls-rs-core/src/lib.rs Outdated Show resolved Hide resolved
mls-rs-core/src/lib.rs Outdated Show resolved Hide resolved
@tomleavy tomleavy merged commit fe24123 into main Feb 13, 2024
21 checks passed
@tomleavy tomleavy deleted the serde2 branch February 13, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants