Add unused proposals to CommitOutput
#67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 91.77% 91.72% -0.05%
==========================================
Files 169 169
Lines 30807 30830 +23
==========================================
+ Hits 28273 28280 +7
- Misses 2534 2550 +16 ☔ View full report in Codecov by Sentry. |
tomleavy
force-pushed
the
unused-proposals
branch
from
9446b47 to
b9ca33a
Compare
- The specialization macro needs to be invoked after the impl block, so that macros generated for this block are available at the specialization point. - Macro qualification is not supported in the crate where the macro is defined.
tomleavy
force-pushed
the
unused-proposals
branch
from
b9ca33a to
6f82803
Compare
stefunctional
approved these changes
Jan 18, 2024
mulmarta
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add unused proposals to CommitOutput . This allows you to understand which proposals were received but not committed to within an epoch without applying the resulting commit. Also added missing external_commit_group_info to FFI on CommitOutput.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.