Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a function to compute ProposalRef from a proposal MlsMessage #60

Merged
merged 5 commits into from
Jan 15, 2024

Conversation

mulmarta
Copy link
Contributor

@mulmarta mulmarta commented Jan 5, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mulmarta mulmarta requested a review from a team as a code owner January 5, 2024 16:13
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (742c946) 91.65% compared to head (bec4062) 92.14%.
Report is 3 commits behind head on main.

Files Patch % Lines
mls-rs/src/group/framing.rs 97.50% 1 Missing ⚠️
mls-rs/src/group/proposal_ref.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   91.65%   92.14%   +0.49%     
==========================================
  Files         167      169       +2     
  Lines       30415    32515    +2100     
==========================================
+ Hits        27877    29962    +2085     
- Misses       2538     2553      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mls-rs/src/group/framing.rs Outdated Show resolved Hide resolved
mls-rs/src/group/framing.rs Outdated Show resolved Hide resolved
stefunctional
stefunctional previously approved these changes Jan 9, 2024
@tomleavy tomleavy merged commit eb98535 into main Jan 15, 2024
20 checks passed
@tomleavy tomleavy deleted the proposal-ref branch January 15, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants