Add tests and fixes for external commit proposal rules #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 91.65% 91.74% +0.09%
==========================================
Files 167 167
Lines 30415 30594 +179
==========================================
+ Hits 27877 28069 +192
+ Misses 2538 2525 -13 ☔ View full report in Codecov by Sentry. |
tomleavy
reviewed
Dec 27, 2023
tomleavy
reviewed
Dec 27, 2023
tomleavy
previously approved these changes
Dec 27, 2023
stefunctional
previously approved these changes
Dec 27, 2023
mulmarta
commented
Dec 28, 2023
mulmarta
dismissed stale reviews from stefunctional and tomleavy
via
9ad1fa6
Co-authored-by: Stephane Raux <[email protected]>
stefunctional
approved these changes
Dec 28, 2023
tomleavy
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that external joiners can commit custom proposals with custom rules.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.