Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more group info #56

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Expose more group info #56

merged 1 commit into from
Dec 19, 2023

Conversation

mulmarta
Copy link
Contributor

Description of changes:

Make a bunch of information about the group from group info and group public. All grouped in GroupContext now.

Call-outs:

This is a breaking change but the previously merged PR already increased versions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mulmarta mulmarta requested a review from a team as a code owner December 18, 2023 17:06
@codecov-commenter
Copy link

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (dcc0df3) 91.72% compared to head (d460fa1) 91.65%.

Files Patch % Lines
mls-rs/src/group/context.rs 22.22% 14 Missing ⚠️
mls-rs/src/group/group_info.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   91.72%   91.65%   -0.07%     
==========================================
  Files         167      167              
  Lines       30393    30415      +22     
==========================================
  Hits        27877    27877              
- Misses       2516     2538      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomleavy tomleavy merged commit 742c946 into main Dec 19, 2023
20 checks passed
@tomleavy tomleavy deleted the api branch December 19, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants