Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update update_senders when an update proposal is removed from the bundle #31

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

stefunctional
Copy link
Contributor

@stefunctional stefunctional commented Nov 13, 2023

Description of changes:

update_senders is now updated when the list of update proposals changes to ensure they stay in sync.

Call-outs:

N/A

Testing:

A test was added to check that the resulting group state is correct when an invalid update proposal was submitted.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@stefunctional stefunctional requested a review from a team as a code owner November 13, 2023 16:23
tomleavy
tomleavy previously approved these changes Nov 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f74a5cc) 91.63% compared to head (1267e9c) 91.97%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   91.63%   91.97%   +0.33%     
==========================================
  Files         167      167              
  Lines       30048    30244     +196     
==========================================
+ Hits        27535    27816     +281     
+ Misses       2513     2428      -85     
Files Coverage Δ
mls-rs/src/group/mod.rs 95.43% <100.00%> (+0.26%) ⬆️
mls-rs/src/group/proposal_filter/filtering.rs 95.33% <80.00%> (-0.24%) ⬇️
mls-rs/src/tree_kem/mod.rs 96.33% <0.00%> (-0.10%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mulmarta mulmarta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this!

@tomleavy tomleavy merged commit 239784f into main Nov 13, 2023
@tomleavy tomleavy deleted the fix-update-senders branch November 13, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants