-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PreSharedKeyStorage from Client and Group #238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomleavy
changed the title
Remove psk store
Remove PreSharedKeyStorage from Client and Group
Jan 14, 2025
mulmarta
reviewed
Jan 14, 2025
mulmarta
reviewed
Jan 14, 2025
mulmarta
reviewed
Jan 14, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.x-main #238 +/- ##
============================================
+ Coverage 90.21% 90.34% +0.12%
============================================
Files 178 177 -1
Lines 31175 31318 +143
============================================
+ Hits 28125 28294 +169
+ Misses 3050 3024 -26 ☔ View full report in Codecov by Sentry. |
tomleavy
force-pushed
the
remove-psk-store
branch
from
January 15, 2025 14:07
d92b3c8
to
f277406
Compare
tomleavy
force-pushed
the
remove-psk-store
branch
from
January 15, 2025 18:45
f277406
to
51ad19e
Compare
mulmarta
reviewed
Jan 16, 2025
mulmarta
reviewed
Jan 16, 2025
mulmarta
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Work towards #211
Resolves #215
Description of changes:
Remove the PreSharedKeyStorage trait from Client and Group operations
Call-outs:
There are some obvious places where there can be optimizations like removing clones or passing an iterator instead of a Vec. Since there are other changes in those areas I am keeping this PR limited to just getting things working and we can take care of those other items later.
Testing:
Adapted all existing tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.