Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PreSharedKeyStorage from Client and Group #238

Merged
merged 25 commits into from
Jan 16, 2025
Merged

Conversation

tomleavy
Copy link
Contributor

@tomleavy tomleavy commented Jan 14, 2025

Issues:

Work towards #211
Resolves #215

Description of changes:

Remove the PreSharedKeyStorage trait from Client and Group operations

Call-outs:

There are some obvious places where there can be optimizations like removing clones or passing an iterator instead of a Vec. Since there are other changes in those areas I am keeping this PR limited to just getting things working and we can take care of those other items later.

Testing:

Adapted all existing tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@tomleavy tomleavy changed the base branch from main to 1.x-main January 14, 2025 04:27
@tomleavy tomleavy changed the title Remove psk store Remove PreSharedKeyStorage from Client and Group Jan 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 97.21254% with 16 lines in your changes missing coverage. Please review.

Project coverage is 90.34%. Comparing base (7b16a02) to head (aac5b68).

Files with missing lines Patch % Lines
mls-rs/src/group/commit/processor.rs 86.27% 7 Missing ⚠️
mls-rs/src/group/external_commit.rs 96.38% 3 Missing ⚠️
mls-rs/src/group/mod.rs 97.56% 3 Missing ⚠️
mls-rs/src/group_joiner.rs 95.89% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           1.x-main     #238      +/-   ##
============================================
+ Coverage     90.21%   90.34%   +0.12%     
============================================
  Files           178      177       -1     
  Lines         31175    31318     +143     
============================================
+ Hits          28125    28294     +169     
+ Misses         3050     3024      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomleavy tomleavy marked this pull request as ready for review January 14, 2025 19:04
@tomleavy tomleavy requested a review from a team as a code owner January 14, 2025 19:04
@mulmarta mulmarta merged commit 1c124a0 into 1.x-main Jan 16, 2025
30 checks passed
@mulmarta mulmarta deleted the remove-psk-store branch January 16, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants