PQ KEMs behind a feature flag #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
- Coverage 90.19% 90.16% -0.04%
==========================================
Files 177 180 +3
Lines 31808 32317 +509
==========================================
+ Hits 28690 29139 +449
- Misses 3118 3178 +60 ☔ View full report in Codecov by Sentry. |
|
Looks like the entire kem combiner is uncovered code, lets fix that |
Looking. It's weird, I'm sure I tested it... |
added 14 commits
January 8, 2025 12:44
mulmarta
force-pushed
the
kyber-rebased
branch
from
f2c0bf9 to
551a63e
Compare
tomleavy
previously approved these changes
Jan 9, 2025
Co-authored-by: Stephane Raux <[email protected]>
tomleavy
approved these changes
Jan 13, 2025
mulmarta
added a commit
that referenced
this pull request
Jan 15, 2025
* wip * Replace round3 submission by ml-kem * Fixup * Rename kyber to ml-kem * Rename kyber to ml-kem * Fixup * Fixup * Fix? * Bump versions * wip * wip * Update aws-lc version. Support Kyber with FIPS * Add tests for combiner * Fixup * Fixup * Fixup * Fixup * Fix warnings, not build FIPS and non-FIPS at the same time * Fixup * Fixup * Fixup :( * Fix key size * Apply suggestions from code review Co-authored-by: Stephane Raux <[email protected]> --------- Co-authored-by: Marta Mularczyk <[email protected]> Co-authored-by: Stephane Raux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements 2 PQ replacements of DH-KEM
Call outs
DH-related functions were only copied
Safety
I did run mls-rs-crypto-aws-lc tests with address sanitizer and stared at the code very long. Unfortunately aws-lc-rs does not currently support
Testing
I would love to run some tests from the XWing RFC but unfortunately they seem to be incompatible with ML-KEM from AWS-LC and they don't contain intermediate values I could use to only test the combiner. We could generate test vectors based on the XWing implementation in the future.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.