Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] ExternalGroup was not able to issue local proposals #210

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

mulmarta
Copy link
Contributor

The line

let can_propose = match (proposer, by_ref) {
    ....
    (Sender::External(_), false) => false,

is wrong and prevents the server from issuing Local proposals

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mulmarta mulmarta requested a review from a team as a code owner November 11, 2024 17:47
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.12%. Comparing base (0532380) to head (71125a6).

Files with missing lines Patch % Lines
mls-rs/src/group/proposal_cache.rs 57.14% 6 Missing ⚠️
mls-rs/src/group/proposal_filter/filtering.rs 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   90.16%   90.12%   -0.04%     
==========================================
  Files         175      175              
  Lines       31448    31446       -2     
==========================================
- Hits        28354    28341      -13     
- Misses       3094     3105      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomleavy tomleavy merged commit b6d257e into main Nov 11, 2024
32 checks passed
@tomleavy tomleavy deleted the fixup branch November 11, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants