Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add count_at_time function to SqLiteKeyPackageStorage #208

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

tomleavy
Copy link
Contributor

@tomleavy tomleavy commented Nov 7, 2024

Description of changes:

Added a function that will tell you how many key packages that are held in storage will remain at a specific time in the future. This is useful in order to preemptively maintain a pool of key packages before they expire on a DS.

Testing:

Added a test to cover this functionality.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@tomleavy tomleavy requested a review from a team as a code owner November 7, 2024 20:20
@tomleavy tomleavy changed the title add count_at_time function to SqLiteKeyPackageStorage Add count_at_time function to SqLiteKeyPackageStorage Nov 7, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (df87607) to head (a7b9887).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #208   +/-   ##
=======================================
  Coverage   90.16%   90.17%           
=======================================
  Files         175      175           
  Lines       31421    31448   +27     
=======================================
+ Hits        28332    28359   +27     
  Misses       3089     3089           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mulmarta mulmarta merged commit 0532380 into main Nov 8, 2024
32 checks passed
@mulmarta mulmarta deleted the key-package-storage branch November 8, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants