Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mls-rs-crypto-cryptokit not building for iOS #206

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

CaioSym
Copy link
Contributor

@CaioSym CaioSym commented Nov 5, 2024

Issues:

TODO

Description of changes:

Fixes mls-rs-crypto-cryptokit to take the target aarch into account when building. Currently it always assumes macos as the target.

Explicitly added support for iphone and iphonesimulator. A more complete fix might want to consider watchOS and TVOS but I currently can't test on those.

Call-outs:

The @available annotations SHOULD be redundant and not needed by the swift compiler since we are specifying the min target OS to be 17. However, i still get errors unless I add them. More investigation is needed on this but parking it for now since the iOS17 reqs are a hard blocker for my project to adopt crypto kit.

Testing:

Tested that building works for the provided archs by running the following. (Assumes you've already installed the toolchains for these archs) on an M1 Mac.

cargo build -vv -p mls-rs-crypto-cryptokit --target aarch64-apple-ios
cargo build -vv -p mls-rs-crypto-cryptokit --target x86_64-apple-ios
cargo build -vv -p mls-rs-crypto-cryptokit --target aarch64-apple-ios-sim
cargo build -vv -p mls-rs-crypto-cryptokit --target aarch64-apple-darwin
cargo build -vv -p mls-rs-crypto-cryptokit --target x86_64-apple-darwin

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@CaioSym CaioSym requested a review from a team as a code owner November 5, 2024 13:56
@tomleavy
Copy link
Contributor

tomleavy commented Nov 5, 2024

@CaioSym looks like you just need to run the fmt tool and we are good

@mulmarta mulmarta merged commit b9f0eae into awslabs:main Nov 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants