Fix mls-rs-crypto-cryptokit not building for iOS #206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
TODO
Description of changes:
Fixes mls-rs-crypto-cryptokit to take the target aarch into account when building. Currently it always assumes macos as the target.
Explicitly added support for iphone and iphonesimulator. A more complete fix might want to consider watchOS and TVOS but I currently can't test on those.
Call-outs:
The @available annotations SHOULD be redundant and not needed by the swift compiler since we are specifying the min target OS to be 17. However, i still get errors unless I add them. More investigation is needed on this but parking it for now since the iOS17 reqs are a hard blocker for my project to adopt crypto kit.
Testing:
Tested that building works for the provided archs by running the following. (Assumes you've already installed the toolchains for these archs) on an M1 Mac.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.