Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more context to ms rules / identity provider callbacks #204

Merged
merged 11 commits into from
Nov 20, 2024
Merged

Conversation

mulmarta
Copy link
Contributor

Maybe useful to know more context

Call-outs

Moving GroupContext to core means making tree_hash and confirmed_transcript_hash public (there's currently a function on ExternalGroup that returns confirmed_transcript_hash anyway).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mulmarta mulmarta requested a review from a team as a code owner October 28, 2024 14:56
@tomleavy
Copy link
Contributor

tomleavy commented Nov 1, 2024

@mulmarta holding off on merging this for a week or so to see if we need any non-breaking changes first

@mulmarta mulmarta marked this pull request as draft November 6, 2024 12:39
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 93.91304% with 14 lines in your changes missing coverage. Please review.

Project coverage is 90.16%. Comparing base (9f4d07f) to head (431ba42).

Files with missing lines Patch % Lines
mls-rs-core/src/group/context.rs 57.89% 8 Missing ⚠️
mls-rs/src/group/mls_rules.rs 55.55% 4 Missing ⚠️
mls-rs-identity-x509/src/provider.rs 0.00% 1 Missing ⚠️
mls-rs/src/group/message_processor.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   90.14%   90.16%   +0.01%     
==========================================
  Files         175      176       +1     
  Lines       31498    31558      +60     
==========================================
+ Hits        28395    28453      +58     
- Misses       3103     3105       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mulmarta mulmarta marked this pull request as ready for review November 6, 2024 13:18
Copy link
Contributor

@tomleavy tomleavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the direction of this! Left some comments

mls-rs-core/src/identity/provider.rs Show resolved Hide resolved
mls-rs-core/src/lib.rs Outdated Show resolved Hide resolved
mls-rs/src/group/message_processor.rs Show resolved Hide resolved
mls-rs/src/group/mod.rs Outdated Show resolved Hide resolved
mls-rs/src/group/proposal_filter/filtering.rs Outdated Show resolved Hide resolved
mls-rs/src/group/transcript_hash.rs Show resolved Hide resolved
@mulmarta
Copy link
Contributor Author

I fixed the merge conflict (version in Cargo.toml), I think I addressed all the comments, and we waited 2 weeks. OK to merge @tomleavy ?

@tomleavy
Copy link
Contributor

I fixed the merge conflict (version in Cargo.toml), I think I addressed all the comments, and we waited 2 weeks. OK to merge @tomleavy ?

Yup, I think we are good

@mulmarta mulmarta merged commit ad3c6e9 into main Nov 20, 2024
32 checks passed
@mulmarta mulmarta deleted the provider-api branch November 20, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants