-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more context to ms rules / identity provider callbacks #204
Conversation
@mulmarta holding off on merging this for a week or so to see if we need any non-breaking changes first |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
+ Coverage 90.14% 90.16% +0.01%
==========================================
Files 175 176 +1
Lines 31498 31558 +60
==========================================
+ Hits 28395 28453 +58
- Misses 3103 3105 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the direction of this! Left some comments
6ea22e0
to
01da3b2
Compare
01da3b2
to
431ba42
Compare
I fixed the merge conflict (version in Cargo.toml), I think I addressed all the comments, and we waited 2 weeks. OK to merge @tomleavy ? |
Yup, I think we are good |
Maybe useful to know more context
Call-outs
Moving GroupContext to core means making
tree_hash
andconfirmed_transcript_hash
public (there's currently a function on ExternalGroup that returnsconfirmed_transcript_hash
anyway).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.