Do not enable modern_sqlite feature #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is a dangerous default as this allows an easy mismatch between headers built against and the library linked to.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
=======================================
Coverage 90.16% 90.16%
=======================================
Files 175 175
Lines 31408 31408
=======================================
Hits 28320 28320
Misses 3088 3088 ☔ View full report in Codecov by Sentry. |
mulmarta
approved these changes
Oct 24, 2024
tomleavy
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
That is a dangerous feature as this allows an easy mismatch between headers built against and the library linked to.
Call-outs:
No quite sure if that should be considered a breaking change. Strictly speaking, it probably is. Let me know if I should bump the minor version number instead.
Testing:
Built locally and ran tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.