Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GroupInfo and Welcome message decryption APIs #188

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Add GroupInfo and Welcome message decryption APIs #188

merged 2 commits into from
Sep 19, 2024

Conversation

mulmarta
Copy link
Contributor

Add APIs to decrypt group info from welcome message (without tree) and validate group info (without tree). They may be useful.

Code in group/mod.rs was copied to a new function but not modified

Testing:

Added unit test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mulmarta mulmarta requested a review from a team as a code owner August 27, 2024 10:43
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 95.33898% with 11 lines in your changes missing coverage. Please review.

Project coverage is 90.00%. Comparing base (e1fba48) to head (f483afd).

Files with missing lines Patch % Lines
mls-rs/src/group/mod.rs 92.79% 8 Missing ⚠️
mls-rs/src/group/util.rs 93.75% 2 Missing ⚠️
mls-rs/src/client.rs 98.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   89.95%   90.00%   +0.04%     
==========================================
  Files         175      175              
  Lines       31106    31266     +160     
==========================================
+ Hits        27981    28140     +159     
- Misses       3125     3126       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mls-rs/src/group/mod.rs Show resolved Hide resolved
@tomleavy tomleavy changed the title Add APIs Add group info and welcome message decryption APIs Sep 19, 2024
@tomleavy tomleavy changed the title Add group info and welcome message decryption APIs Add GroupInfo and Welcome decryption APIs Sep 19, 2024
@tomleavy tomleavy changed the title Add GroupInfo and Welcome decryption APIs Add GroupInfo and Welcome message decryption APIs Sep 19, 2024
@mulmarta mulmarta merged commit a7b0422 into main Sep 19, 2024
30 checks passed
@mulmarta mulmarta deleted the apis branch September 19, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants