Add RemoveProposal to the Removed case of CommitEffect #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
=======================================
Coverage 89.94% 89.94%
=======================================
Files 175 175
Lines 31084 31091 +7
=======================================
+ Hits 27959 27966 +7
Misses 3125 3125 ☔ View full report in Codecov by Sentry. |
mulmarta
previously approved these changes
Jul 19, 2024
stefunctional
previously approved these changes
Jul 19, 2024
mulmarta
approved these changes
Jul 19, 2024
stefunctional
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes:
The removed case of CommitEffect didn't provide any details about who removed you, so we should provide the proposal that triggered your removal
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.