[crypto-rustcrypto]: remove unused custom feature #161
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 89.65% 89.63% -0.02%
==========================================
Files 175 175
Lines 31578 31578
==========================================
- Hits 28310 28305 -5
- Misses 3268 3273 +5 ☔ View full report in Codecov by Sentry. |
|
Seems to be used by embedded build @mgeisler. Maybe you could add this? |
The `custom` feature from `getrandom` is not actually used in normal builds — infact, `getrandom` itself is never used directly. However, the feature can be used by a binary on an embedded platform to register a custom random number generator. The final binary should enable the `custom` feature to do this, see the `register_custem_genrandom!` macro for more details: https://docs.rs/getrandom/latest/getrandom/macro.register_custom_getrandom.html We emulate this in the CI build by enabling the feature on the command line.
mgeisler
force-pushed
the
remove-getrandom-custom
branch
from
68eaa11 to
a80c868
Compare
|
Thanks @mulmarta for the debugging! I finally came back to this and I think I understand what the problem is. Based on reading It should instead be enabled by the final binary. I've updated the CI script to do this and I hope it'll work now. |
mulmarta
approved these changes
Sep 19, 2024
stefunctional
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We don’t actually use the “custom” feature of the getrandom crate. We don't have the feature enabled in all the places where I'm trying to use mls-rs, so it would be nice if this crate doesn't require it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.