Simplify X.509 certificate validity check (#247)

This is now 5 lines of code, but I feel they’re simpler lines than what came before.
awslabs · Jan 23, 2025 · 0e6faa4 · 0e6faa4
1 parent c198d38
commit 0e6faa4
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/mls-rs-crypto-rustcrypto/src/x509/validator.rs b/mls-rs-crypto-rustcrypto/src/x509/validator.rs
@@ -142,9 +142,11 @@ fn verify_time(cert: &Certificate, time: MlsTime) -> Result<(), X509Error> {
     let not_before = validity.not_before.to_unix_duration().as_secs();
     let not_after = validity.not_after.to_unix_duration().as_secs();
 
-    (not_before <= now && now <= not_after)
-        .then_some(())
-        .ok_or_else(|| X509Error::ValidityError(now, format!("{cert:?}")))
+    if not_before <= now && now <= not_after {
+        Ok(())
+    } else {
+        Err(X509Error::ValidityError(now, format!("{cert:?}")))
+    }
 }
 
 fn verify_cert(