Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DataVpc construct #283

Merged
merged 3 commits into from
Dec 8, 2023
Merged

feat: DataVpc construct #283

merged 3 commits into from
Dec 8, 2023

Conversation

vgkowski
Copy link
Contributor

@vgkowski vgkowski commented Dec 7, 2023

Issue #, if available:

Description of changes:

Add a new construct for creating a standard VPC for data platforms including VPC flow logs in CLoudWatch log group and S3 VPC endpoint

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@vgkowski vgkowski force-pushed the feature/vpc-construct branch from 4a30839 to e133323 Compare December 7, 2023 14:48
@vgkowski vgkowski marked this pull request as ready for review December 7, 2023 14:48
@vgkowski vgkowski added the e2e-ready This PR is ready to be E2E-tested label Dec 7, 2023
@github-actions github-actions bot added e2e-testing This PR is currently being E2E-tested e2e-completed The E2E tests have completed on this PR and removed e2e-ready This PR is ready to be E2E-tested e2e-testing This PR is currently being E2E-tested labels Dec 7, 2023
@vgkowski
Copy link
Contributor Author

vgkowski commented Dec 7, 2023

I have ran the e2e test that failed because of exceeded quota and it passed

@lmouhib lmouhib added e2e-ready This PR is ready to be E2E-tested and removed e2e-completed The E2E tests have completed on this PR labels Dec 7, 2023
@github-actions github-actions bot added e2e-testing This PR is currently being E2E-tested and removed e2e-ready This PR is ready to be E2E-tested labels Dec 7, 2023
Copy link
Contributor

@lmouhib lmouhib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor comments

framework/src/utils/lib/data-vpc-props.ts Show resolved Hide resolved
framework/src/utils/lib/data-vpc-props.ts Show resolved Hide resolved
framework/src/utils/lib/data-vpc-props.ts Outdated Show resolved Hide resolved
framework/src/utils/lib/data-vpc.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added e2e-completed The E2E tests have completed on this PR and removed e2e-testing This PR is currently being E2E-tested labels Dec 7, 2023
Copy link
Contributor

@lmouhib lmouhib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmouhib lmouhib merged commit dce1deb into main Dec 8, 2023
2 checks passed
@lmouhib lmouhib deleted the feature/vpc-construct branch December 8, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-completed The E2E tests have completed on this PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants