Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade ESLint #195

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

hakanson
Copy link
Contributor

@hakanson hakanson commented Jan 31, 2025

Issue #, if available: #196

Description of changes:

Updated actions/checkout to v4, actions/setup-node to v4, and node-version to 18 in workflows

Update to ESLint 9.x (v8 is EOL per https://eslint.org/version-support/)

  • updated related eslint packages and upgrade eslint-plugin-security
  • ran npx @eslint/migrate-config .eslintrc.js per Configuration Migration Guide to create eslint.config.mjs
  • --ignore-path .gitignore on command line replaced with setting in eslint.config.mjs
  • set @typescript-eslint/no-require-imports to "off" in some test files
  • removed unused eslint-disable-next-line

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hakanson hakanson requested a review from ottokruse January 31, 2025 19:57
@hakanson
Copy link
Contributor Author

hakanson commented Jan 31, 2025

Looks like structuredClone used by ESLint security plugin was introduced in Node.js 17.0.0 and we run on 16. Created #196 and updating workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant