Alb jwt verifier #190
Draft
Alb jwt verifier #190
+1,629
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 great work @NicolasViaud ! And super important. Will review incrementally, likely over the next few days. For now, can you run |
|
And maybe to be sure |
ottokruse
reviewed
Jan 15, 2025
src/alb-verifier.ts
Outdated
| const regions = albArn.map(extractRegion); | ||
| const uniqueRegions = Array.from(new Set(regions)); | ||
| if (uniqueRegions.length > 1) { | ||
| throw new ParameterValidationError("Multiple regions found in ALB ARNs"); |
There was a problem hiding this comment.
Good catch hadn’t considered this yet! Side effect of allowing multiple ALB ARNs in one configuration is that you have to guard against this now.
I think it’s not unreasonable to throw this error. It’s probably very niche to create a verifier for multiple ALBs in different regions, I can’t see why you would ever want that.
What's your take?
add unit test for alb-verifier.ts (reach 100% coverage)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#109
Description of changes:
Proposition for an AwsAlbJwksCache implementation.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.