Remove TODOs to put into github issues #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavaleri
commented
Jul 22, 2020
| @@ -381,10 +381,6 @@ and MUST release the message footer. | |||
| The encrypted message outputted by this operation MUST have a message footer equal | |||
| to the message footer calculated in this step. | |||
|
|
|||
| ## Security Considerations | |||
|
|
|||
| [TODO] | |||
|
|
||
| ## Security Considerations | ||
|
|
||
| [TODO] |
| @@ -345,5 +341,3 @@ C051AD55 A437F6BC 139E9E55 6199FD60 | |||
| B66B6A5A 80FDB433 8A48D6A4 21CB | |||
| 811234FD 8D589683 51F6F39A 040B3E3B Final Frame, Authentication Tag | |||
| ``` | |||
|
|
|||
| ### TODO - ADD example for single frame | |||
| @@ -191,10 +191,6 @@ It is used to authenticate the final frame. | |||
| The authentication tag length MUST be equal to the authentication tag length of the algorithm suite | |||
| specified by the [Algorithm Suite ID](message-header.md#algorithm-suite-id) field. | |||
|
|
|||
| ## Test Vectors | |||
|
|
|||
| [TODO](https://github.com/awslabs/aws-crypto-tools-test-vector-framework) | |||
| @@ -100,7 +100,7 @@ The purpose of the message ID is to: | |||
| - protect against accidental reuse of a derived data key or the wearing out of derived data keys in | |||
| the AWS Encryption SDK | |||
| - uniquely identify the [message](message.md) | |||
| - bind the message header to the [message body](message-body.md) [TODO "bind" wording] | |||
| - bind the message header to the [message body](message-body.md) | |||
There was a problem hiding this comment.
Leaving word as is. Exactly what security property is associated with this word will be addressed as part of #200
| @@ -173,10 +173,6 @@ the caching CMM MUST add the decryption materials obtained from the underlying C | |||
| If the [algorithm suite](algorithm-suites.md) requested contains an Identity KDF, | |||
| the caching CMM MUST NOT store the decryption materials in the underlying CMC. | |||
|
|
|||
| ## Security Considerations | |||
|
|
|||
| [TODO: What security properties can the caching CMM guarantee?] | |||
| @@ -386,11 +386,6 @@ These goals can be reduced to the following two requirements: | |||
| that is an error and encryption MUST halt. | |||
| 1. On decrypt, the keyring MUST NOT halt decryption because of a failure to decrypt. | |||
|
|
|||
| ## Security Considerations | |||
|
|
|||
| [TODO: What security properties are guaranteed by this keyring? Also, note how the security properties | |||
| @@ -118,9 +118,6 @@ still do not contain a plaintext data key: | |||
|
|
|||
| ## Security Considerations | |||
|
|
|||
| TODO: what security guarantees does this keyring have? | |||
|
|
||
| ## Security Considerations | ||
|
|
||
| [TODO: What security properties are guaranteed by this keyring] |
|
|
||
| ## Security Considerations | ||
|
|
||
| [TODO: What security properties does this keyring guarantee?] |
acioc
approved these changes
Jul 22, 2020
alex-chew
approved these changes
Jul 22, 2020
lavaleri
added a commit
to lavaleri/aws-encryption-sdk-specification
that referenced
this pull request
Jul 22, 2020
Co-authored-by: Alex Chew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
moved into issues:
captured in existing issues:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.