Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grand dispatch queue #661
base: main
Are you sure you want to change the base?
Grand dispatch queue #661
Changes from 168 commits
9389f14
e825924
452217c
c0d4086
84fd773
98c8ef0
89e8ece
9c27144
f375bb2
41a5fa1
04c2b93
0d301d2
4afaea6
a7f6904
89635db
195ca1c
24ce65b
287094f
bd58da0
f0e5dde
aef1b14
41bb257
22e68b2
a28cb37
c67e966
3ca34ce
f8c26f5
a428cd8
5ab8f24
0918e76
a55f14f
06fb206
ed04764
e8fe46d
a84cb5a
977bb8a
ce07c5a
0210346
a751d76
b44c510
b0f85f2
7bc39ee
475c1f2
cf592a7
1803c0f
9d97302
9781845
754c56d
974a9b2
0b7b061
75e4f45
4a784cc
381f3dd
e63c0a8
09cff00
ca3a134
6619695
7a89d9e
56fa4d1
c1a4971
470164b
977c4f7
9e6d574
eab14fa
d8f5fdd
9323cc3
b771d8c
4f3048e
fcb3d9a
9b16a3b
a30cd39
74733ad
558d179
16d4e25
55de953
74019cf
5d22a69
600421e
7cb0936
f808b35
e84a1a6
d79b5b7
3ce216c
6233c9d
4a8007a
70008b1
0f75185
f7fb5a2
8bd9808
16861b9
8d946db
17c7cca
1212977
afd634d
d68acdb
6b92e59
3999196
6f1984c
8d84d11
71fae6f
35efc2e
405c988
e614bdc
e22131a
51e2d5a
8be6cd2
94f95c1
ab05a35
61cbc90
4d0e12c
22c6363
c507d13
c54b99e
69cbb09
7b51b56
5fc5270
aa876a1
ee7fa76
7d20796
2fb32ab
f5a5338
7ea8588
1cbe989
667e41a
48ad48c
17b79a4
a32ee15
c53b4ad
ad5152c
1afb859
691aa17
182757f
02afc29
6610f79
53fc1fc
2461b43
6783915
6fcd019
85bf6ce
ef012d3
31a9a95
8bb613e
7cdd319
e1d7513
d45eb98
98c558e
c8e57c5
cfa0399
f4414aa
e1ce086
a93216b
1cc1633
7adfffb
485e376
5e1e728
893f94b
18b5d82
f9ff79a
98ea949
6933da0
16c36e8
d986649
54f4883
84c6c4c
cce6210
7058676
52fe388
c2dab8d
4fadfee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarity needed. I don't think we're using nw_connection_t unless dispatch queue is turned on.
"On Apple systems using dispatch queue event loops handle is of type nw_connection_t"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you changed this to
AWS_EVENT_LOOP_PLATFORM_DEFAULT
asAWS_ELT_PLATFORM_DEFAULT
doesn't exist.Also, it looks like there is nothing returned on a failure to retrieve the default type value. I think its a compile time error?