Add sagemaker-open-notebook-extension #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes look good to me. Looks like there are credential issues running the automated tests. These tests were recently added and seem like there are some complications when the changes are being requested from a fork. @cinlo can you manually run the cypress test to ensure there are no regressions. You can follow the readme here https://github.com/aws/sagemaker-code-editor/blob/main/test/integ/README.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR introduces a new extension called "SageMaker Open Notebook Extension" to enhance the functionality of the SageMaker Code Editor. The extension allows users to download, transform, and display sample notebooks from a specified Amazon S3 bucket directly within the Code Editor environment.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.