Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use security group policy to manage pod-eni resource #7607

Merged
merged 1 commit into from
Jan 18, 2025
Merged

chore: Use security group policy to manage pod-eni resource #7607

merged 1 commit into from
Jan 18, 2025

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Jan 18, 2025 •
edited
Loading

Fixes #N/A

Description

  • Using security group policy to define the pod-eni resource instead of defined it in the deployment
  • The VPC resource controller will track ENIs using the security group policy CR for finalization. Using the SGP CR will ensure ENIs are not leaked as part of the test cleanup

How was this change tested?

  • /karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner January 18, 2025 01:49
@engedaam engedaam requested a review from rschalo January 18, 2025 01:49
@netlify Netlify
Copy link

netlify bot commented Jan 18, 2025 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 41a732a
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/678b0a80412002000918378d

@coveralls
Copy link

coveralls commented Jan 18, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12839800715

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 64.986%
Totals Coverage Status
Change from base Build 12815498828: 0.003%
Covered Lines: 5776
Relevant Lines: 8888
💛 - Coveralls

engedaam
engedaam commented Jan 18, 2025
View reviewed changes
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

jmdeal
jmdeal approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 69ed8b9 into aws:main Jan 18, 2025
32 of 33 checks passed
@engedaam engedaam deleted the fix_sgpp_test branch January 18, 2025 05:19
edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Jan 22, 2025
@engedaam @edibble21
chore: Use security group policy to manage pod-eni resource (aws#7607)
75cf5be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@rschalo rschalo Awaiting requested review from rschalo rschalo is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jmdeal