-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Convert mentions of do-not-evict
to do-not-disrupt
#7539
Conversation
The Troubleshooting docs were out of date with v1.0+ (as per this post mentioning deprecation of the `do-not-evict` annotation.) Figured I'd clean that up to reduce confusion!
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also make this change to preview and 1.1 version of the docs?
Pull Request Test Coverage Report for Build 12586212725Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I'd love to! Not sure how to make that happen, though. 😅 I saw a mention of |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Update: Found it! Given the changes elsewhere, should I remove the changes to |
No, we should keep the changes in the docs folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
The Troubleshooting docs were out of date with v1.0+ (as per this post mentioning deprecation of the
do-not-evict
annotation.) Figured I'd clean that up to reduce confusion!NOTE: I'm not entirely sure how this works with already published docs versions, so any guidance there would be quite welcome. Thanks!
Probably doesn't need testing?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.