Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Convert mentions of do-not-evict to do-not-disrupt #7539

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

trevenrawr
Copy link
Contributor

@trevenrawr trevenrawr commented Dec 17, 2024

The Troubleshooting docs were out of date with v1.0+ (as per this post mentioning deprecation of the do-not-evict annotation.) Figured I'd clean that up to reduce confusion!

NOTE: I'm not entirely sure how this works with already published docs versions, so any guidance there would be quite welcome. Thanks!

Probably doesn't need testing?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The Troubleshooting docs were out of date with v1.0+ (as per this post mentioning deprecation of the `do-not-evict` annotation.)  Figured I'd clean that up to reduce confusion!
@trevenrawr trevenrawr requested a review from a team as a code owner December 17, 2024 23:55
@trevenrawr trevenrawr requested a review from njtran December 17, 2024 23:55
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit a5dfb50
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6776cb63eb8afb000871c892
😎 Deploy Preview https://deploy-preview-7539--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also make this change to preview and 1.1 version of the docs?

@coveralls
Copy link

coveralls commented Dec 18, 2024

Pull Request Test Coverage Report for Build 12586212725

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.125%

Totals Coverage Status
Change from base Build 12383377998: 0.0%
Covered Lines: 5774
Relevant Lines: 8866

💛 - Coveralls

@trevenrawr
Copy link
Contributor Author

Can we also make this change to preview and 1.1 version of the docs?

I'd love to! Not sure how to make that happen, though. 😅 I saw a mention of /preview in the PR template, but I'm not sure where that is.

Copy link
Contributor

github-actions bot commented Jan 2, 2025

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@trevenrawr
Copy link
Contributor Author

Update: Found it! Given the changes elsewhere, should I remove the changes to docs/troubleshooting ?

@engedaam
Copy link
Contributor

engedaam commented Jan 7, 2025

No, we should keep the changes in the docs folder

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam enabled auto-merge (squash) January 7, 2025 18:13
@engedaam engedaam merged commit bfdc2d9 into aws:main Jan 7, 2025
17 checks passed
@trevenrawr trevenrawr deleted the patch-1 branch January 7, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants