feat(pacmak): support jsii-rosetta 5.7 #4718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
commented
Nov 29, 2024
There was a problem hiding this comment.
removed whitespace because yq cannot deal with that and will remove it.
mrgrain
commented
Nov 29, 2024
There was a problem hiding this comment.
jsii & jsii-rosetta were previously excluded because they were part of the monorepo. We just want to handle upgrades for these two separately.
mrgrain
commented
Nov 29, 2024
There was a problem hiding this comment.
re-ordered some package because automated tooling is sorting the packages
otaviomacedo
approved these changes
Dec 2, 2024
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for jsii-rosetta 5.7 to jsii-pacmak.
This also changes the peer dependency to simply state the minimal required version.
This will make it less urgent for us to actually release a new version of jsii-pacmak.
Also includes a new script to fully automate the uprade.
A future extension would be to run this script from a workflow.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.