Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocky support for nodeadm + tests #305

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vignesh-goutham
Copy link
Member

@vignesh-goutham vignesh-goutham commented Jan 23, 2025

Description of changes:
Adding rocky support for nodeadm along with few validations and e2e tests

Testing (if applicable):
Tested E2E with amd and arm for both Rocky 8 and 9

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@jaxesn jaxesn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not 100% sure what we want to do with this yet, suggested breaking 1 thing out that we can merge. If there is are other things you think make sense without adding rocky, break those out and we can discuss offline how to proceed with this one.

internal/creds/creds.go Show resolved Hide resolved
@@ -31,7 +31,7 @@ import (
const (
nodePodWaitTimeout = 3 * time.Minute
nodePodDelayInterval = 5 * time.Second
hybridNodeWaitTimeout = 10 * time.Minute
hybridNodeWaitTimeout = 12 * time.Minute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rocky slower than rhel?!

go.mod Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants