feat: call destory on all cached clients on deactivation

aws · Feb 24, 2025 · f44f714 · f44f714
1 parent 6fdfdc0
commit f44f714
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/packages/core/src/extensionNode.ts b/packages/core/src/extensionNode.ts
@@ -261,6 +261,7 @@ export async function activate(context: vscode.ExtensionContext) {
 export async function deactivate() {
     // Run concurrently to speed up execution. stop() does not throw so it is safe
     await Promise.all([await (await CrashMonitoring.instance())?.shutdown(), deactivateCommon(), deactivateEc2()])
+    globals.sdkClientBuilderV3.clearServiceCache()
     await globals.resourceManager.dispose()
 }
 

diff --git a/packages/core/src/shared/awsClientBuilderV3.ts b/packages/core/src/shared/awsClientBuilderV3.ts
@@ -140,6 +140,13 @@ export class AWSClientBuilderV3 {
         service.middlewareStack.add(getEndpointMiddleware(serviceOptions.settings), { step: 'build' })
         return service
     }
+
+    public clearServiceCache() {
+        for (const client of this.serviceCache.values()) {
+            client.destroy()
+        }
+        this.serviceCache.clear()
+    }
 }
 
 export function getServiceId(context: { clientName?: string; commandName?: string }): string {