[develop] Restrict extra permissions for ECR private repo as Lambda team has confirmed they are unnecessary

[hehe7318]

Description

• This PR removes the extra ECR policy actions ecr:DeleteRepositoryPolicy, ecr:GetRepositoryPolicy, and ecr:SetRepositoryPolicy from our CloudFormation template.
• As confirmed by the Lambda team, Lambda only needs ecr:BatchGetImage and ecr:GetDownloadUrlForLayer to pull images from ECR. The additional three permissions are used only when Lambda has to manage a repository policy that doesn’t already exist.
• By explicitly defining the minimal set of permissions in our template, we prevent CloudFormation from overwriting or deleting them during future updates.

How Has This Been Tested?

• Deployed to a personal AWS account with only BatchGetImage and GetDownloadUrlForLayer.
• Verified that Lambda can still successfully fetch images from ECR.
• Repeated stack updates (e.g., adding tags) to confirm the policy is retained.

References

• [BugFix] Explicitly set the policy for ECR private repo so prevent policy removal on stack update impacting Lambda function #373

PR Quality Checklist

• I added tests to new or existing code
• I removed hardcoded strings and used react-i18next library (useTranslation hook and/or Trans component), see an example here
• I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
• I made sure that any GitHub issue solved by this PR is correctly linked
• I checked that infrastructure/update_infrastructure.sh runs without any error
• I checked that npm run build builds without any error
• I checked that clusters are listed correctly
• I checked that a new cluster can be created (config is produced and dry run passes)
• I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.