Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Avoid surfacing errors in the UI that are caused by failures in interacting with Cost Explorer, regardless the failure root cause. #267

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

gmarciani
Copy link
Collaborator

Avoid surfacing errors in the UI that are caused by failures in interacting with Cost Explorer, regardless the failure root cause.

Changes

  1. Replaced the error notification at the UI level with a console log
  2. Added unit tests to cover the scenario

How Has This Been Tested?

  1. Unit tests
  2. Manual test verifying that errors are not displayed in the UI when access to Cost Explorer is forbidden by a permissions boundary
  3. Manual test verifying that the cost monitoring feature behaves as expected in the UI when the permission boundary is removed and the access to Cost Explorer has recovered.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…es in interacting with Cost Explorer, regardless the failure root cause.
@gmarciani gmarciani requested a review from mendaomn October 13, 2023 14:02
@gmarciani gmarciani merged commit 792ac85 into aws:main Oct 13, 2023
@gmarciani gmarciani deleted the wip/mgiacomo/fix-cost-monitoring branch October 13, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants