Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Add support for Memory Based Scheduling with Multiple Instance Types in ParallelCluster 3.7.0+. #266

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

gmarciani
Copy link
Collaborator

Changes

Add support for Memory Based Scheduling with Multiple Instance Types in ParallelCluster 3.7.0+.

Known Limitations
The wizard does not remove the schedulable memory property in the resulting cluster config when mem based scheduling is enabled and then disabled. This is not a blocking bug because the resulting cluster config is valid, but simply an unexpected behaviour that we may decide to address in another iteration.

How Has This Been Tested?

  1. Unit tests
  2. Manual verification with Pcluster 3.7.0: mem based scheduling can be toggled and preserved with input cluster config when using multiple instance types in 3.7.0. Verified with dryrun creation.
  3. Manual verification with Pcluster 3.6.0: feature flagging is working as expected prohibiting the use of mem based scheduling with multiple instance types. Verified with dryrun creation.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gmarciani gmarciani requested a review from mendaomn October 13, 2023 10:31
@gmarciani gmarciani merged commit cb83175 into aws:main Oct 13, 2023
@gmarciani gmarciani deleted the wip/mgiacomo/mem-based-sched-370 branch October 13, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants