Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ParallelCluster 3.7.0 #263

Merged
merged 6 commits into from
Oct 12, 2023

Conversation

gmarciani
Copy link
Collaborator

@gmarciani gmarciani commented Oct 10, 2023

Description

Add support for ParallelCluster 3.7.0

Changes

  1. pcluster version bumped to 3.7.0 in CloudFormation template and demo env.
  2. 3.7.0 features added to feature flags provider + new unit tests covering it.
  3. Add Amazon File Cache as a supported shared storage within the Wizard (both frontend and backend changes). This change was considered out of scope at first, but discovered that it was actually easier to introduce it than modifying the inner logic to silently avoid it. Moreover we are providing feature parity for File Cache that is certainly valuable for our users.
  4. Documentation: added to DEVELOPMENT.md some valuable information about development process learned during this iteration.

Known Limitations

  1. With this change we are not achieving the full feature parity with ParallelCluster 3.7.0. In fact we are missing in the Wizard: support for Ubuntu 22.04 and support for Memory Based Scheduling with Flexible Instance Types. Nevertheless the lack of this feature parity is not a blocker for the wizard.
  2. Unit tests for the backend on API GET:/manager/get_aws_configuration have been considered out of scope because they must be written from the ground up and we will cover in a follow up PR.

How Has This Been Tested?

  1. Unit tests on the backend
  2. Unit tests on the frontend
  3. Manual test: created a cluster using a cluster config file exercising all the config-impactful features introduced in ParallelCluster 3.7.0: Ubuntu22.04, Login Nodes, Memory Based Scheduling, Amazon File Cache.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gmarciani gmarciani requested a review from BarcoMasile October 10, 2023 16:53
@gmarciani gmarciani changed the title Bump pcluster version to 3.7.0 Bump pcluster version to 3.7.0 + features flagging Oct 10, 2023
himani2411
himani2411 previously approved these changes Oct 10, 2023
@gmarciani gmarciani force-pushed the wip/mgiacomo/support-3.7.0 branch from 15be007 to 7144e08 Compare October 12, 2023 12:51
@gmarciani gmarciani changed the title Bump pcluster version to 3.7.0 + features flagging Add support for ParallelCluster 3.7.0 Oct 12, 2023
@gmarciani gmarciani force-pushed the wip/mgiacomo/support-3.7.0 branch from 7144e08 to cfb62c1 Compare October 12, 2023 13:23
himani2411
himani2411 previously approved these changes Oct 12, 2023
Copy link
Contributor

@mendaomn mendaomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

frontend/src/old-pages/Configure/Storage.tsx Outdated Show resolved Hide resolved
@gmarciani gmarciani merged commit 9244695 into aws:main Oct 12, 2023
@gmarciani gmarciani deleted the wip/mgiacomo/support-3.7.0 branch October 12, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants