Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add development instructions to DEVELOPMENT.md + folders to gitignore #262

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

gmarciani
Copy link
Collaborator

Description

  1. Add development instructions to DEVELOPMENT.md.
  2. Add to gitignore: idea folder and personal env files.

How Has This Been Tested?

No test needed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gmarciani gmarciani added the documentation Improvements or additions to documentation label Oct 10, 2023
@gmarciani gmarciani requested a review from himani2411 October 10, 2023 15:45
@@ -9,3 +9,6 @@ infrastructure/cognitolambda/node_modules
public/*
/frontend/tsconfig.tsbuildinfo
.idea/
.ignore
infrastructure/environments/*
!infrastructure/environments/demo-*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we add the demo-* folder in gitignore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The combo

infrastructure/environments/*
!infrastructure/environments/demo-*

means ignore everything in that folder but demo env files.

We added this because we want demo files to be tracked.

@himani2411 himani2411 self-requested a review October 10, 2023 15:59
@gmarciani gmarciani merged commit de7c161 into aws:main Oct 10, 2023
2 checks passed
@gmarciani gmarciani deleted the wip/mgiacomo/dev-process branch October 10, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants