Update eif_build tool #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atanzu
force-pushed
the
update_eif_build_tool
branch
from
381ff72 to
350cf1d
Compare
atanzu
force-pushed
the
update_eif_build_tool
branch
from
350cf1d to
bee6f49
Compare
eugkoira
reviewed
Jan 15, 2025
eugkoira
reviewed
Jan 15, 2025
meerd
reviewed
Jan 15, 2025
This commit updates `aws-nitro-enclaves-image-format` to 0.4 and modifies the source code to make it buildable with this updated dependency. Signed-off-by: Mark Kirichenko <[email protected]>
This commit bumps MSRV to 1.71 in order to support the same MSRV as for `aws-nitro-enclaves-image-format` library. Signed-off-by: Mark Kirichenko <[email protected]>
This commit packs parameters of function `eif_build` into a structure in order to reduce number of parameters it takes. Signed-off-by: Mark Kirichenko <[email protected]>
atanzu
force-pushed
the
update_eif_build_tool
branch
from
bee6f49 to
d816d7e
Compare
This commit adds a new command line option `--algo` for `eif_build` tool which allows to specify the hashing algorithm used to measure the image. Signed-off-by: Mark Kirichenko <[email protected]>
atanzu
force-pushed
the
update_eif_build_tool
branch
from
d816d7e to
a67ae47
Compare
eugkoira
approved these changes
Jan 15, 2025
meerd
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-nitro-enclaves-cli#204
#34
Description of changes:
This is a updated version of #20 because it needed to be rebased and split between the library part and the binary tool
We extend EIF building functionality with additional option of signing EIF files with KMS.
sign_infoparameter of EifBuilder now turned to a structure that contains enum for the signing key.This enum can be represented as local private key (previous functionality) or KMS signing key (implemented in COSE library).
This PR contains the following changes:
aws-nitro-enclaves-image-formatto 0.4.eif_buildwith the new command line arguments:kms-key-id: ARN of the KMS key to be used to sign the EIF.kms-key-region: region of the KMS key.algo: algorithm to use for measurements, possible values:sha256,sha384,sha512.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.