Update BORINGSSL_FIPS_abort to AWS_LC_FIPS_failure which takes a message #2182
+166
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhop
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2182 +/- ##
==========================================
+ Coverage 78.98% 79.02% +0.03%
==========================================
Files 611 612 +1
Lines 105878 106064 +186
Branches 14984 14994 +10
==========================================
+ Hits 83633 83817 +184
- Misses 21588 21594 +6
+ Partials 657 653 -4 ☔ View full report in Codecov by Sentry. |
justsmth
approved these changes
Feb 10, 2025
Comment on lines
+190
to
+192
| #define MAX_WITHIN_MSG_LEN sizeof(ASSERT_WITHIN_MSG) + (3 * STRING_POINTER_LENGTH) + MAX_FUNCTION_NAME | ||
| #define ASSERT_OUTSIDE_MSG "FIPS module spans unexpected symbol (%s), expected %p < %p || %p > %p\n" | ||
| #define MAX_OUTSIDE_MSG_LEN sizeof(ASSERT_OUTSIDE_MSG) + (4 * STRING_POINTER_LENGTH) + MAX_FUNCTION_NAME |
There was a problem hiding this comment.
NP: I don't think so much precision is needed for the MAX_xxx_MSG_LEN values. Those arrays are only on the stack in the case of a failure during library initialization -- as long as the array is not so large as to cause compilation to fail, it should be fine. A "large" number like 4096 would be way more than sufficient.
skmcgrail
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In preparation for the callback change in #2162 this change updates all the place that could abort to pass a message to a new abort function that explains why it's about to abort.
Testing:
The existing test-break-kat.go will ensure all the KATs still fail as expected and the messages they print match.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.