Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nginx build #2181

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Fix Nginx build #2181

merged 2 commits into from
Feb 10, 2025

Conversation

smittals2
Copy link
Contributor

Issues:

Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2

Description of changes:

Updating patch for nginx build

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@smittals2 smittals2 requested a review from a team as a code owner February 8, 2025 00:01
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.02%. Comparing base (41060fe) to head (b6dc61e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2181      +/-   ##
==========================================
+ Coverage   78.98%   79.02%   +0.03%     
==========================================
  Files         611      612       +1     
  Lines      105878   106071     +193     
  Branches    14984    14995      +11     
==========================================
+ Hits        83633    83821     +188     
- Misses      21588    21596       +8     
+ Partials      657      654       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smittals2 smittals2 enabled auto-merge (squash) February 8, 2025 01:31
@smittals2 smittals2 merged commit bd4baa1 into aws:main Feb 10, 2025
116 of 120 checks passed
@justsmth
Copy link
Contributor

Duplicate? #2184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants