-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove InstancesDistribution from unmanaged nodegroup cfn #448
Conversation
@@ -317,8 +317,10 @@ Resources: | |||
Properties: | |||
AutoScalingGroupName: !Ref ResourceId | |||
MixedInstancesPolicy: | |||
{{- if .Features.InstancesDistribution }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we even need the InstancedDistribution
? I just copied this from an unmanaged nodegroup example to begin with, wr can probably just remove it entirely if it's not available everywhere.
or we can just use a CFN intrinsic func to switch this off in certain partitions, if that's what we're getting at. Would be easier than pushing that logic up to the user of the deployer IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in that case i think i'd rather pull it out because it doesn't seem required 🤔
not sure if the parameters will affect runtimes based on capacity of Spot vs OnDemand, but the instance type prioritization seems like the only real different behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack, can you test and make sure the nodes still come up without this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran a test successfully and updated the overview with the steps
This reverts commit 13ee4e9.
Issue #, if available:
N/A
Description of changes:
Remove
InstancesDistribution
from unmanaged nodegroup cloudformation templates since it may not be supported in certain regions.Testing: