Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AMISSMParameter option from unmanaged nodegroup template #415

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Remove AMISSMParameter option from unmanaged nodegroup template #415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions kubetest2/internal/deployers/eksapi/templates/unmanaged-nodegroup.yaml.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,8 @@ Parameters:

AMIId:
Type: String
Default: ""
Description: Specify AMI id for the node instances.

AMISSMParameter:
Type: "AWS::SSM::Parameter::Value<AWS::EC2::Image::Id>"
Default: /aws/service/eks/optimized-ami/{{.KubernetesVersion}}/amazon-linux-2/recommended/image_id
Description: AWS Systems Manager Parameter Store parameter of the AMI ID for the worker node instances. Only used if AMIId is not specified.

NodeDiskSize:
Type: Number
Description: Node disk size in gigabytes.
Expand Down Expand Up @@ -69,9 +63,6 @@ Parameters:
SSHSecurityGroup:
Type: String

Conditions:
HasAMIId: !Not [ !Equals [ !Ref AMIId, "" ] ]

Resources:
NodeInstanceProfile:
Type: AWS::IAM::InstanceProfile
Expand Down Expand Up @@ -139,11 +130,7 @@ Resources:
--region ${AWS::Region}
IamInstanceProfile:
Arn: !GetAtt NodeInstanceProfile.Arn
ImageId:
!If
- HasAMIId
- !Ref AMIId
- Ref: AMISSMParameter
ImageId: !Ref AMIId
InstanceType: "{{index .InstanceTypes 0}}"
BlockDeviceMappings:
- DeviceName: /dev/xvda
Expand Down