chore(GHA): Run Java CI testing for MPL Latest Release #1605
Conversation
| uses: ./.github/workflows/dafny-interop.yml | ||
| with: | ||
| mpl-dafny: ${{needs.getLatestReleaseMplVersion.outputs.version}} | ||
| mpl-commit: ${{needs.getMplDafnyVersion.outputs.dafnyVersion}} |
There was a problem hiding this comment.
this doesn't make sense, why for the mpl commit are we supplying the dafny version?
There was a problem hiding this comment.
Because the MPL version will be built with its own Dafny version, and we pick this up from the project properties file of the MPL.
There was a problem hiding this comment.
Look at the first input to dafny-interop.yml.
| workflow_dispatch: # allows triggering this manually through the Actions UI | ||
| # TODO: Remove this before merging to main. We don't want this workflow running in CI | ||
| # on PRs because we expect it to fail when the MPL is actually updated since the last version. |
There was a problem hiding this comment.
Add a flag which by default is on, and if off, doesn't run 105-113 (Test Vectors) but runs the examples. Needed so that if TVs fail, we're still able to test examples.
| # This makes sure that we are using the correct MPL version to test the DB-ESDK. | ||
| # If this contains a SNAPSHOT version, this will fail because' | ||
| # we are NOT building the MPL recursively but pulling from Maven. | ||
| - name: Update project.properties to use the correct MPL version (from project.properties in DB-ESDK) | ||
| working-directory: ./submodules/MaterialProviders/ | ||
| run: | | ||
| sed "s/mplVersion=.*/mplVersion=${{needs.getMplDependencyJavaVersion.outputs.version}}/g" project.properties > project.properties2; mv project.properties2 project.properties |
There was a problem hiding this comment.
should this happen before we build and deploy to maven local on line 72?
There was a problem hiding this comment.
The maven local deploy above this is only for DB-ESDK.
This is required for the MPL test vectors we run after this step.
Issue #, if available:
Description of changes:
Adds a daily job to check that the HEAD of DB-ESDK is compatible with the latest release of the MPL (pulled from Maven).
An important part is that this should be independent of Daily CI / Push CI / Pull CI, because when the MPL is actually updated, we will see errors with testing the last release, and we don't want our current CI process to get affected because of this.
We also won't need to go through the pain of running the MCM step to run dafny-interop.yml manually for the latest released version of the MPL. This new workflow does it automatically, and the oncall just needs to verify that everything is green.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.