Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SharedCache): Shared Cache for Searchable Encryption #1476

Merged
merged 37 commits into from
Jan 24, 2025
Merged

feat(SharedCache): Shared Cache for Searchable Encryption #1476

merged 37 commits into from
Jan 24, 2025

Conversation

RitvikKapila
Copy link
Contributor

@RitvikKapila RitvikKapila commented Nov 20, 2024 •
edited
Loading

Issue #, if available:

Description of changes:
This PR:

  • Adds support for a shared cache for Searchable Encryption beacons.
  • Updates the cache identifiers for Searchable Encryption to be consistent with the MPL Hierarchical Keyring identifier and Caching CMM identifier.
  • Updates the smithy model for MultiKeyStore to add an optional variable partitionId.
  • Updates the smithy model for SingleKeyStore to add two optional variables: partitionId and cache.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@RitvikKapila and @texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

1 similar comment
@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

@RitvikKapila and @ajewellamz, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@RitvikKapila RitvikKapila force-pushed the rkapila/shared-cache-beacons branch from 7a001ea to ee868b0 Compare December 15, 2024 01:49
@github-actions GitHub Actions
Copy link

@RitvikKapila and @ajewellamz, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@RitvikKapila and @ajewellamz, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

1 similar comment
@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

seebees
seebees reviewed Jan 22, 2025
View reviewed changes
specification/searchable-encryption/search-config.md Outdated Show resolved Hide resolved
specification/searchable-encryption/search-config.md Outdated Show resolved Hide resolved
specification/searchable-encryption/search-config.md Outdated Show resolved Hide resolved
specification/searchable-encryption/search-config.md Outdated Show resolved Hide resolved
specification/searchable-encryption/search-config.md Outdated Show resolved Hide resolved
specification/searchable-encryption/search-config.md Outdated Show resolved Hide resolved
specification/searchable-encryption/search-config.md Outdated Show resolved Hide resolved
specification/searchable-encryption/search-config.md Outdated Show resolved Hide resolved
specification/searchable-encryption/search-config.md Outdated Show resolved Hide resolved
specification/searchable-encryption/search-config.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

@RitvikKapila and @seebees, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

9 similar comments
@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

@RitvikKapila and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

seebees
seebees approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

@RitvikKapila and @seebees, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@RitvikKapila RitvikKapila merged commit 46076f8 into main Jan 24, 2025
40 checks passed
@RitvikKapila RitvikKapila deleted the rkapila/shared-cache-beacons branch January 24, 2025 00:50
RitvikKapila pushed a commit that referenced this pull request Jan 27, 2025
@semantic-release-bot
chore(release): 3.8.0 [skip ci]
2ce53c2 
## [3.8.0](v3.7.0...v3.8.0) (2025-01-27)

### Features

* **SharedCache:** Shared Cache for Searchable Encryption ([#1476](#1476)) ([46076f8](46076f8))

### Fixes

* ensure algorithmSuite is properly copied in getTableConfig for E… ([#1474](#1474)) ([ff3acac](ff3acac))
* **Java:** Improve Collection of Errors string ([#1478](#1478)) ([562b3ef](562b3ef))
* **SearchableEncryption:** disable shared cached ([#1507](#1507)) ([ffc67be](ffc67be))
* **SearchableEncryption:** respect CMC contract ([#1434](#1434)) ([b9333fb](b9333fb))
* support new input validation ([#1518](#1518)) ([12bbfbf](12bbfbf))
* Upgrade .net DDB SDK ([8aeed4e](8aeed4e))

### Maintenance

* add dependabot for rust ([#1481](#1481)) ([67f3d2e](67f3d2e))
* Add ECDH examples ([#1461](#1461)) ([cc937b4](cc937b4))
* add Rust release directory ([#1479](#1479)) ([97dde01](97dde01))
* add rust support ([#1376](#1376)) ([98ddfe9](98ddfe9))
* always use dotnet 6 for format checking. ([#1403](#1403)) ([2b85507](2b85507))
* bump macos from 12 to 13 in CI ([#1472](#1472)) ([1abb2dd](1abb2dd))
* Bump to MPL HEAD, Smithy-Dafny HEAD ([#1299](#1299)) ([b2674a9](b2674a9))
* change exported names, update docs ([#1524](#1524)) ([640b4d7](640b4d7))
* **CI:** make smithy fidd check smarter ([#1381](#1381)) ([bb399bf](bb399bf))
* **CI:** mpl head step for rust ([#1583](#1583)) ([98724d3](98724d3))
* create Rust release runbook ([#1488](#1488)) ([e51f340](e51f340))
* enable local testing ([#1380](#1380)) ([36f48b0](36f48b0))
* **examples:** Shared cache across Hierarchical Keyrings ([#1410](#1410)) ([21f7fe1](21f7fe1))
* **GHA:** Add pr-ci-all-required to pull.yaml; use ubuntu-22.04 instead of ubuntu-latest in CI ([#1579](#1579)) ([c231473](c231473))
* **gha:** fix workflows triggered by dafny-interop.yml ([#1598](#1598)) ([0cb009d](0cb009d))
* **gha:** use ubuntu-22.04 ([#1594](#1594)) ([5e24233](5e24233))
* **Java:** bump conversion library ([#1423](#1423)) ([8931e27](8931e27))
* new mpl ([#1530](#1530)) ([fe03425](fe03425))
* **README:** point to release examples ([#1525](#1525)) ([a4ca2f9](a4ca2f9))
* **Rust-docs:** Update README ([#1520](#1520)) ([96dd848](96dd848))
* **rust:** add comments to release scripts ([7b45929](7b45929))
* slight updates to properly publish as a crate ([#1480](#1480)) ([aa9175b](aa9175b))
* update for complete copyright notices ([#1489](#1489)) ([c0ec84d](c0ec84d))
* update Github alias ([dc6ca47](dc6ca47))
* update Github alias ([ff4500a](ff4500a))
* update MPL ([#1519](#1519)) ([b0a97e0](b0a97e0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texastony texastony texastony left review comments

@ajewellamz ajewellamz ajewellamz left review comments

@seebees seebees seebees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RitvikKapila @seebees @texastony @ajewellamz