fix(eks-v2-alpha): can't delete fargate cluster

[xazhao]

Issue # (if applicable)

Closes #33347.

Reason for this change

The fargate cluster deletion issue is because the cluster admin access entry is deleted before deleting KubernetesPatch.

Since deleting KubernetesPatch requires applying a restore patch to the cluster, it will still need the cluster access. In this case, because the access entry is deleted, kubectl provider won't be able to apply the patch to the cluster anymore.

Description of changes

add an explicit dependency from patch to the access entry so the patch will only be deleted after the access entry

Description of how you validated changes

unit tests/integration tests

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (528e5df) to head (3b35344).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33573   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         119      119           
  Lines        6876     6876           
  Branches     1162     1162           
=======================================
  Hits         5653     5653           
  Misses       1120     1120           
  Partials      103      103           

Flag	Coverage Δ
suite.unit	82.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	∅ <ø> (∅)
packages/aws-cdk-lib/core	82.21% <ø> (ø)

[GavinZZ]

Why do we need to set LAMBDA_CREATE_NEW_POLICIES_WITH_ADDTOROLEPOLICY? I see you mentioned in description that without this it will create new policy when running the test. Is this happening in main as well?

[xazhao]

@GavinZZ yes without this change, I see integration tests failed with following changes:

[~] AWS::IAM::Policy ClusterKubectlProviderframeworkonEventServiceRoleDefaultPolicyA4F24629
 └─ [~] PolicyDocument
     └─ [~] .Statement:
         └─ @@ -24,5 +24,15 @@
            [ ]         ]
            [ ]       }
            [ ]     ]
            [+]   },
            [+]   {
            [+]     "Action": "lambda:GetFunction",
            [+]     "Effect": "Allow",
            [+]     "Resource": {
            [+]       "Fn::GetAtt": [
            [+]         "ClusterKubectlProviderHandler2E05C68A",
            [+]         "Arn"
            [+]       ]
            [+]     }
            [ ]   }
            [ ] ]

It only happens in my local though. CodeBuild looks fine. I'm not sure if it happens to other people.

[aws-cdk-automation]

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 3b35344
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.