Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stepfunctions): add support for custom CSV delimiters in S3CsvItemReader #33558

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Feb 22, 2025

Issue # (if applicable)

Closes #33418.

Reason for this change

CSVDelimiter in ItemReader is not supported in L2 Construct.

Ref: https://docs.aws.amazon.com/step-functions/latest/dg/input-output-itemreader.html#itemreader-field-contents

Description of changes

Add csvDelimiter property.

Describe any new or updated permissions being added

Nothing.

Description of how you validated changes

Add a unit test and an integ test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Feb 22, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 22, 2025 09:24
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Feb 22, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.20%. Comparing base (8dcbde3) to head (c67f07b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33558   +/-   ##
=======================================
  Coverage   82.20%   82.20%           
=======================================
  Files         119      119           
  Lines        6862     6862           
  Branches     1158     1158           
=======================================
  Hits         5641     5641           
  Misses       1118     1118           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.20% <ø> (ø)

@mazyu36
Copy link
Contributor Author

mazyu36 commented Feb 22, 2025

Exemption Request: The details of options for CSV and JSON readers are not written, so I did not add this time either.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Feb 22, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 24, 2025
@mazyu36
Copy link
Contributor Author

mazyu36 commented Feb 24, 2025

@Mergifyio update

Copy link
Contributor

mergify bot commented Feb 24, 2025

update

✅ Branch has been successfully updated

@mazyu36
Copy link
Contributor Author

mazyu36 commented Feb 24, 2025

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Feb 24, 2025

refresh

✅ Pull request refreshed

@GavinZZ GavinZZ added the pr-linter/exempt-readme The PR linter will not require README changes label Feb 25, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 25, 2025 01:35

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Feb 25, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c67f07b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Feb 25, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 43ae4fc into aws:main Feb 25, 2025
20 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2025
@mazyu36 mazyu36 deleted the feature/sfn-csv-delimiter-33418 branch February 25, 2025 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(stepfunctions): No option for CSV Delimiter
3 participants