-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vpc-v2): add add
methods to RouteTable and SubnetV2
#31072
Changes from all commits
31d3f48
727b164
cb8c941
d21be53
42830e7
2f48ab2
f904a97
b52d498
1aef528
9b15a4b
bc56a77
cc8db35
285da27
98f9d53
b3e08c1
1211fde
ca9c385
eaa7ccb
a25bb78
1721026
bc393c2
aed940f
499c6c8
f296f3e
0002de5
909f7da
1b907c1
0dba8bb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we are doing an override rather than creating a new
CfnSubnetRouteTableAssociation
L1. If we create a new one, we would have to find some way to remove the old association L1, otherwise they will both show up in the template, and may confuse users who synthesize and see two associations for one table. The override allows us to use the same L1 object, just alter which route table it points to.