-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): diff
allow specifying changeSet
via cdk.json
#29375
Changes from 6 commits
8bcba5c
ad0d49c
f0553df
3d782dd
a8fbfc4
f056ce2
df07d8e
da815c5
9cd365e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -514,7 +514,7 @@ export async function exec(args: string[], synthesizer?: Synthesizer): Promise<n | |||||
stream: args.ci ? process.stdout : undefined, | ||||||
compareAgainstProcessedTemplate: args.processed, | ||||||
quiet: args.quiet, | ||||||
changeSet: args['change-set'], | ||||||
changeSet: configuration.settings.get(['diff', 'changeSet']) ?? args['change-set'], | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps this needs to be swapped so that the cdk.json setting can be overridden via the cli argument? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you are right about this order of operations. Only question is if there is a difference between no flag being provided and the default. If the flag is always given a value regardless of being set, we may have to put the context first (but I will ask some others on the team about this). |
||||||
}); | ||||||
|
||||||
case 'bootstrap': | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 - thank you! This message appears too often now.