unit tests

aws · Mar 2, 2025 · 45a276f · 45a276f
1 parent d80bd69
commit 45a276f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 11 deletions.
diff --git a/packages/aws-cdk-lib/aws-iam/lib/role.ts b/packages/aws-cdk-lib/aws-iam/lib/role.ts
@@ -272,14 +272,7 @@ export class Role extends Resource implements IRole {
       dummyValue: [
         {
           // eslint-disable-next-line @cdklabs/no-literal-partition
-          // Arn: 'arn:aws:iam::123456789012:role/DUMMY_ARN',
-          Arn: Stack.of(scope).formatArn({
-            region: '',
-            account: '123456789012',
-            service: 'iam',
-            resource: 'role',
-            resourceName: 'DUMMY_ARN',
-          }),
+          Arn: 'arn:aws:iam::123456789012:role/DUMMY_ARN',
         },
       ],
     }).value;

diff --git a/packages/aws-cdk-lib/aws-iam/test/role.from-lookup.test.ts b/packages/aws-cdk-lib/aws-iam/test/role.from-lookup.test.ts
@@ -1,5 +1,5 @@
 import * as cxschema from '../../cloud-assembly-schema';
-import { ContextProvider, Stack, Token } from '../../core';
+import { CfnParameter, ContextProvider, Stack, Token } from '../../core';
 import * as iam from '../lib';
 
 /* eslint-disable */
@@ -46,10 +46,14 @@ describe('Role from lookup', () => {
 
   test('throw error if role name is a token', () => {
     // GIVEN
-    const tokenName = Token.asString('MyExistingRole');
     const stack = new Stack(undefined, undefined, { env: { region: 'us-east-1', account: '123456789012' } });
+    const param = new CfnParameter(stack, 'MyParam', {
+      type: 'String',
+      default: 'MyExistingRole',
+    });
+
     expect(() => iam.Role.fromLookup(stack, 'MyRole', {
-      roleName: tokenName,
+      roleName: param.valueAsString,
     })).toThrow(/All arguments to look up a role must be concrete \(no Tokens\)/);
   });
 });