Added AWS_STS_REGIONAL_ENDPOINTS flag/annotation #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahhausler
force-pushed
the
sts-regional-endpoints
branch
from
0d09994 to
454d3b4
Compare
jaypipes
suggested changes
Apr 28, 2020
| @@ -323,11 +337,6 @@ func (m *Modifier) Handle(w http.ResponseWriter, r *http.Request) { | |||
| body = data | |||
| } | |||
| } | |||
| if len(body) == 0 { | |||
There was a problem hiding this comment.
Any reason this was removed?
There was a problem hiding this comment.
Yea, this error wasn't helpful and didn't return an AdmissionReview I could add it back and just return an actual AdmissionReview with a more helpful error message instead of attempting to process the empty body
micahhausler
force-pushed
the
sts-regional-endpoints
branch
from
454d3b4 to
e95bb68
Compare
jaypipes
previously approved these changes
Nov 4, 2020
| pod := &corev1.Pod{} | ||
| err = yaml.Unmarshal(data, pod) | ||
| return pod, err | ||
| } |
There was a problem hiding this comment.
very nice test cleanup and separation of fixtures into testdata. ++
micahhausler
force-pushed
the
sts-regional-endpoints
branch
from
e95bb68 to
aaab99f
Compare
lnalex
added a commit
to lnalex/amazon-eks-user-guide
that referenced
this pull request
Mar 22, 2021
IRSA in a private cluster requires the use of STS VPC endpoints. However, the most AWS SDKs use the global STS endpoint by default for the STS `AssumeRoleWithWebIdentity` call, which bypasses the STS VPC endpoint (and fails in a private cluster).
To make this work correctly, we may need to explicitly instruct the SDK to use the regional STS endpoint. Usually this is done by passing some environment variables:
```yaml
- env:
- name: AWS_REGION
value: <REGION>
- name: AWS_STS_REGIONAL_ENDPOINTS
value: regional
```
Relevant info:
aws/amazon-eks-pod-identity-webhook#55 (Note: `eks.amazonaws.com/sts-regional-endpoints` doesn't appear to be supported yet in EKS)
https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_sts_vpce.html#id_credentials_sts_vpce_create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
The default for most AWS v1 SDKs is to use the global STS endpoint (
https://sts.amazonaws.com, hosted inus-east-1) when talking to STS, resulting in a cross-region call for anything not inus-east-1just to get credentials. (some v2 SDKs such as Java v2 use regional). The way to force AWS SDKs to use the regional STS endpoint is to add theAWS_STS_REGIONAL_ENDPOINTSenvironment variable and set the value toregional.For applications running in Kubernetes pods using this webhook, this setting can now be automatically configured by adding the ServiceAccount annotation
eks.amazonaws.com/sts-regional-endpointswith a value of"true", or if operating this webhook on a cluster, setting the webhook flag--sts-regional-endpoint=true.If the webhook's flag value is set to regional (
--sts-regional-endpoint=true), but the environment variable is not desired, individual ServiceAccounts can opt-out by setting the annotation toeks.amazonaws.com/sts-regional-endpoints: "false".Note that IAM administrators can disable regional STS, and any applications that attempt to use a regional STS endpoint on a disabled region will get an error.