pin the version of nvidia-container-toolkit #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yiyuanzzz
force-pushed
the
pin-nvidia-version
branch
from
d887508 to
fafa3e1
Compare
|
Could you add in the PR description why we are pinning to this version? I believe there is a bug in 1.17.1 that we can reference somewhere? |
prateekchaudhry
approved these changes
Dec 6, 2024
danehlim
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr update our recipe to pin the version of nvidia-container-toolkit rpms to 1.16.2 so that we don't release version 1.17.1 with known bug NVIDIA/nvidia-container-toolkit#797.
Implementation details
Testing
New tests cover the changes:
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.