Tag name for update check's ec2 run-instances call #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danehlim
force-pushed
the
tag-check-security-ec2-run-instance
branch
from
3a54bdb to
ba0d6fe
Compare
prateekchaudhry
approved these changes
Dec 3, 2024
mye956
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a "Name" tag to EC2 RunInstances API call in
scripts/check-update-security.shshell script so that it is easier to identify instances launched via this shell script in the calling AWS account.Implementation details
Use
--tag-specificationsargument when callingaws ec2 run-instancesto add "Name" tag to instance that indicates that the instance is used for checking for security updates (and the platform it is checking security updates for).Testing
Manually run the modified command locally using personal AWS account and confirm that the launched instance has the expected "Name" tag.
New tests cover the changes: no
Description for the changelog
Tag name for update check's ec2 run-instances call
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.