feat: Expose variables to set AMI share permisions #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @leigholiver for your contribution! I also tested this locally with AL1, AL2, AL2023, and AL2023 ARM and it seems to working as expected. Seems like this option was introduced on version v1.0.6 of packer-plugin-amazon. Since we're requiring the version to be at least |
mye956
force-pushed
the
ami-sharing-vars
branch
from
aeb6b41 to
216f070
Compare
|
You might need to format all of the packer files via a |
danehlim
force-pushed
the
ami-sharing-vars
branch
from
216f070 to
e93f968
Compare
danehlim
force-pushed
the
ami-sharing-vars
branch
from
e93f968 to
0031457
Compare
danehlim
approved these changes
Nov 26, 2024
mye956
approved these changes
Nov 26, 2024
|
Thank you again @leigholiver for your contribution! This pull request has now been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exposes the
ami_ou_arns,ami_org_arns, andami_usersvariables for configuration.Resolves #30
Implementation details
Adds three entries to
variables.tffor these variables, and pass them through to the underlyingebs_buildersTesting
I have built and deployed both the
al2andal2armvariants. Unfortunately themake testscommand mentioned doesnt appear to exist but im happy to run any additional tests needed.New tests cover the changes: no
Description for the changelog
Feature - Support AMI sharing
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.